Skip to content

Conversation

@olegpro
Copy link
Contributor

@olegpro olegpro commented Nov 29, 2025

No description provided.

@olegpro
Copy link
Contributor Author

olegpro commented Dec 4, 2025

@mac-cain13 review pls

@pieterocp
Copy link
Contributor

pieterocp commented Feb 4, 2026

Since working on the issue and seeing a local CI failure, there's a failing test in symfony:^8.0

See: https://github.com/symfony/symfony/blob/8.1/UPGRADE-8.0.md#console

Remove deprecated Symfony\Component\Console\Application::add() method in favor of Symfony\Component\Console\Application::addCommand()

The rest of the application is probably fine though.

Throwing to the test tests/Wrep/Daemonizable/Command/EndlessCommandRunloopTest.php:22 something like the below would work to keep the tests working.

-        $application->add($command);
+        if (method_exists($application, 'add')) {
+            $application->add($command);
+        } elseif (method_exists($application, 'addCommand')) {
+            $application->addCommand($command);
+        } else {
+            throw new \LogicException('check symfony docs since both are gone.');
+        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants